-
Notifications
You must be signed in to change notification settings - Fork 23
Modernize dependencies #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build d73ae85f-f1f1-4087-a108-236b4f50fea8
💛 - Coveralls |
All dependencies are up-to-date EXCEPT node-fetch which must be kept at v2.6.7. Updating node-fetch is not possible without converting the whole project to ESM, which would be a terrible idea and all kinds of work.
|
Currently broken because of restify node18 problem. Issue: restify/node-restify#1925 Sadly the public links to these projects cannot be hidden, sorry if you're here from Restify :( |
|
Restify supports node18 today via: |
…d starting Backend/AutoTestDaemon
…age (which is the v5 branch right now), but I don't know where that image is.
|
@winstan This seems to be ready to try on a host. I can't merge to master because 310 is still taking changes and I don't want to risk the changes to the DB/Node this late in the term. Is there a dev instance somewhere we can spin up from this PR? |
packages/proxy/Dockerfile
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM nginx:1.13-alpine | |||
| FROM node:lts-alpine | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you meant to change the container from nginx to node... I think you meant to change it to this?
FROM nginx:stable-alpine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed, good catch!
|
Also @winstan, if you happen to know what mongo image to use other than |
Sorry, nope. :( |
|
@rtholmes : Dev hosts: classy-dev and cs210-dev. I've given you access to both. (Talk to Paul about cs210-dev.) |
|
If you want a cs310-dev host, send a request to help@cs... |
I almost wonder if we want to use |
…k to v5 (a v5lts tag would be best, but this does not seem to exist)
|
Playing some more with getting the db to run... Complained of missing processor extension AVX. I found a way to update the processor model for the VM and now everything seems to start up and run fine. (classy-dev) |
|
@winstan glad you got it going! I'm running a modern mongo on my local dev instance so the db behaviours should be ok, but I never thought about that kind of problem! I do know they changed the auth mechanism though (there have been warnings on the terminal for a while) so I'll have to look into those (next week) and see whether I need to change how we open connections to mongo. |
|
@winstan I moved 310 onto a branch so this is probably good to merge to master. This might also be a good time (after the merge) to rename |
Sure, sounds good. |
Status
Overview
PR for fixing #428
mongo:latestdocker image.Notes worth knowing
node-fetchhas to stay at v2.X; v3 only supports ESM modules (which we don't want to transition to).