Fix multiple issues with NewClassTrees that have enclosing expressions#1191
Merged
Fix multiple issues with NewClassTrees that have enclosing expressions#1191
NewClassTrees that have enclosing expressions#1191Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1191 +/- ##
============================================
+ Coverage 88.21% 88.22% +0.01%
+ Complexity 2314 2310 -4
============================================
Files 88 88
Lines 7553 7551 -2
Branches 1511 1508 -3
============================================
- Hits 6663 6662 -1
Misses 446 446
+ Partials 444 443 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
nullaway/src/test/java/com/uber/nullaway/CoreTests.java:1138
- [nitpick] Consider renaming the test method 'issue1888' to a more descriptive name that reflects its intent, which could help with long-term code readability.
@Test public void issue1888() {
nullaway/src/main/java/com/uber/nullaway/NullAway.java:444
- [nitpick] The logic for handling the enclosing expression could be refactored into a helper method for improved clarity and maintainability.
ExpressionTree enclosingExpression = tree.getEnclosingExpression();
yuxincs
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1188, exactly as suggested in that issue. This both simplifies the code and fixes a false negative with
@Nullableenclosing expressions.