Conversation
Collaborator
Author
|
Required job names will need to be updated before landing |
Collaborator
|
@msridhar it seems that the build is failing? 🤔 |
Collaborator
Author
|
Yup, we do have some tests failing on JDK 24 with the new Error Prone version, I'll have to dig into it. Switching to draft for now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1203 +/- ##
=========================================
Coverage 88.21% 88.21%
Complexity 2317 2317
=========================================
Files 88 88
Lines 7577 7577
Branches 1513 1513
=========================================
Hits 6684 6684
Misses 448 448
Partials 445 445 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@yuxincs tests are passing and the is is ready for review now |
msridhar
added a commit
that referenced
this pull request
Apr 28, 2025
Small optimization over #1203; pre-compile the `Pattern` used for matching.
dhruv-agr
pushed a commit
to dhruv-agr/NullAway
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a couple of minor new warnings. Also, pulling in EP 2.38.0 pulls in the latest version of Guava for our tests, and this Guava version has more JSpecify annotations. This new Guava version exposed a bug in our logic for stripping annotations out of method signatures on recent JDK versions, for varargs arrays; we fix it here.