-
Notifications
You must be signed in to change notification settings - Fork 322
Generate astubx from JSON output of jdk-javac-plugin #1243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
106 commits
Select commit
Hold shift + click to select a range
6f03bf9
cli that generates astubx with json files
haewiful 8dc633e
generate json -> astubx
haewiful 91f7565
generate json files
haewiful 98b7e17
Generate astubx files from json files
haewiful 8c05a7b
test-annotated project
haewiful 9e95626
cleanup
haewiful 8b9fef8
test-unannotated
haewiful 1f0d60f
Merge remote-tracking branch 'upstream/master' into jdk-javac
haewiful 50f693f
Merge branch 'master' into jdk-javac
msridhar ea7ae5f
change class name
haewiful d760f35
duplicated line
haewiful 09c260a
integration tests
haewiful cd218b2
change struct classes to records & use GSON instead of Jackson
haewiful 72fcb3f
format
haewiful 3a50196
link two tasks to make sure compileJava runs before generateAstubx
haewiful 9fa6c6f
removing JarInfer tests
haewiful 50280a5
Merge branch 'master' into jdk-javac
msridhar c237927
comments
haewiful facf57c
add test-annotated jar to test-unannotated jar
haewiful cab854b
add provider
haewiful 8c414de
add test-annotated dependency in test-unannotated build.gradle
haewiful 556463b
some changes for test cases
haewiful ccccab2
Merge branch 'master' into jdk-javac
haewiful 86f3169
cleanup
haewiful 01dab0a
formatting
msridhar afcbd93
moved provider file from test-annotated to test-unannotated
haewiful e5d394f
put astubx file in the right place
msridhar 1c55d55
Astubx file format test
haewiful 1f863c3
build.gradle for test
haewiful 8b2bd34
clean up
haewiful 66a4e33
clean up
haewiful 270a5b3
add return type to JSON file
haewiful 8bf8ff4
removing Nullable annotation
haewiful 7a2b946
fix nullable upperbound class name
haewiful eb6ddc5
remove recursively checking a class or method is NullMarked or NullUn…
haewiful a4f57d4
check enclosing type for NullMarked, NullUnmarked
haewiful 3c0036f
put fully qualified class name
haewiful d9514bb
always add method to astubx regardless of annotation
haewiful f99d51f
check nullness of generic type return types
haewiful 4606d5d
Ensure the javac plugin is on the compile classpath
haewiful a8b966a
accept coderabbitai reviews
haewiful 8be7389
break down generateAstubx method into several methods
haewiful 8661cac
formatting
haewiful dc18cd1
more clean up
haewiful 0f6e29b
minor clean up
haewiful d01c857
comment changes
haewiful 8ea48d7
Merge branch 'master' into jdk-javac
msridhar 6d696fe
disable jdk 17 tests
msridhar 4435ecb
fixes
msridhar b36367e
JDK version for compile and test
haewiful 43ba45a
JDK version control for compiler and test
haewiful 3a9175a
coderabbit feedback based changes
haewiful b2fcf57
clean up
haewiful fec7ee0
changes based on initial comments
haewiful 50dfc39
use CompilationTestHelper for compiling test case with plugin
haewiful 98d32ea
formatting
haewiful 104ab65
Merge branch 'master' into jdk-javac
msridhar 0b3c003
add some comments
msridhar c384085
build.gradle comments
haewiful 812dee0
use records in NullnessAnnotationSerializer
haewiful 4e26862
Revert "use records in NullnessAnnotationSerializer"
haewiful 0364b24
Revert "build.gradle comments"
haewiful 62cdecf
build.gradle changes
haewiful 9c5690d
make AstubxGeneratorCLI use records from NullnessAnnotationSerializer…
haewiful 837122d
remove all annotations in arguments not just @Nullable
haewiful 0ca6542
separate writing astubx and returning AstubxData
haewiful 8707978
parse all json files
haewiful 8ef5e62
separate astubx generator and cli
haewiful 959617e
format
haewiful fbff8f2
formatting
haewiful 0f6d00d
Merge branch 'master' into jdk-javac
msridhar 5eb966e
disable testJdk17
msridhar fa49a13
fix coverage
msridhar fb57ab7
one more
msridhar fd3df10
cleanup
msridhar fd8a92e
Merge branch 'master' into jdk-javac
msridhar a3cdf12
some CodeRabbit review changes
haewiful a454624
modify checking upper bounds for a generic return type
haewiful d115c85
changed generic return type logic, added comment, made AstubxData cla…
haewiful 5783dc0
separate parsing json to AstubxData and writing it as a astubx file
haewiful 16f0ea1
check astubx file generation in AstubxTest
haewiful f50531a
add a message saying jdk17 shouldn't be used
haewiful 545566f
use shadowJar of cli instead of running the code directly
haewiful 186303d
added some comments
haewiful 19ca20f
remove unused dependency
haewiful 17927b1
cleanup
msridhar 68a26d0
whoops undo some changes
msridhar 5e56373
fix gradle files
msridhar ee3d04c
cleanup
msridhar c76b947
spotless
msridhar 6647e38
more cleanup
msridhar b799283
try just using the project
msridhar 042b0a9
CodeRabbit feedback fixes
haewiful dc0a558
javadoc
haewiful 62bbd65
use regex pattern matching to extract the arguments & rename variables
haewiful 239e1c4
more clean way to add arguments to method signature
haewiful 0891649
change obtaining argument list logic
haewiful 90fb83c
preserve suffixes after removing type parameters
haewiful d2121d8
add an integration test
msridhar caaf406
Update jdk-annotations/astubx-generator/src/test/java/com/uber/nullaw…
msridhar b043e1c
remove print
msridhar bd29e7d
coderabbit suggestion
msridhar 3c0dd32
fix tests
msridhar 148cae4
remove type argument annotations
haewiful 49a3db1
Merge branch 'master' into jdk-javac
msridhar 1640a9e
add integration test
msridhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
generate json files
- Loading branch information
commit 91f756546148385d7c355329926f55eadc3712da
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather than this dependence, the
generateAstubxtask should depend on the shadow jar output of":jdk-annotations:astubx-generator-cli"?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By changing the task to use the shadowJar generated from the CLI project, I removed this dependency.