Skip to content

Fix URL for RequireExplicitNullMarking checker #1369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msridhar merged 3 commits into from
Dec 6, 2025
Merged

Fix URL for RequireExplicitNullMarking checker #1369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0d85ca
Fix URL for RequireExplicitNullMarking checker
msridhar Dec 5, 2025
7bb824f
comment on trailing space
msridhar Dec 5, 2025
c9a9e44
remove trailing space
msridhar Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nullaway/src/main/java/com/uber/nullaway/RequireExplicitNullMarking.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,9 @@ private static boolean hasNullMarkedOrNullUnmarkedAnnotation(Symbol symbol) {
return ASTHelpers.hasDirectAnnotationWithSimpleName(symbol, "NullMarked")
|| ASTHelpers.hasDirectAnnotationWithSimpleName(symbol, "NullUnmarked");
}

@Override
public String linkUrl() {
return "https://github.com/uber/NullAway/wiki/JSpecify-Support#requireexplicitnullmarking-checker";
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
12 changes: 12 additions & 0 deletions nullaway/src/test/java/com/uber/nullaway/RequireExplicitNullMarkingTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,18 @@ public void missingNullMarkedAnnotationOnTopLevelClass() {
.doTest();
}

@Test
public void defaultURL() {
compilationHelper
.addSourceLines(
"test/MissingAnnotation.java",
"package test;",
"// BUG: Diagnostic contains: https://github.com/uber/NullAway/wiki/JSpecify-Support#requireexplicitnullmarking-checker",
"class MissingAnnotation {",
"}")
.doTest();
}

/** Test that at SUGGESTION level, no report is made for missing annotations */
@Test
public void noReportAtDefaultLevel() {
Expand Down