Update to Checker Framework 3.53.0

[msridhar]

Pulls in a small performance improvement from typetools/checker-framework#7397 and new APIs from typetools/checker-framework#7418 that let us delete some custom implementations in NullAway

Summary by CodeRabbit

• Chores

  • Updated check-framework dependency to version 3.53.0.

• Refactor

  • Refactored internal data flow handling to modify how contextual data is passed between components.
  • Removed an internal retrieval method from the analysis framework.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request updates the check-framework dependency from version 3.49.2 to 3.53.0 and refactors the dataflow analysis API. The public getStoreBefore(Tree tree) method and its overloads are removed from RunOnceForwardAnalysisImpl. Correspondingly, calls to getStoreBefore in DataFlow.java are updated to pass an empty HashMap as an additional argument. Related imports are cleaned up as part of these modifications.

Suggested reviewers

• yuxincs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Update to Checker Framework 3.53.0' directly describes the main change: updating the Checker Framework dependency version from 3.49.2 to 3.53.0 and refactoring related code.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI Agents

In @gradle/libs.versions.toml:
- Line 3: The libs.versions.toml entry for check-framework is set to a
non-existent version "3.53.0"; update the check-framework version string to
"3.52.0" (the latest stable release) in the libs.versions.toml file so
dependency resolution uses the correct Maven Central version.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b1d1e05 and 08a8fc3.

📒 Files selected for processing (3)

• gradle/libs.versions.toml
• nullaway/src/main/java/com/uber/nullaway/dataflow/DataFlow.java
• nullaway/src/main/java/com/uber/nullaway/dataflow/RunOnceForwardAnalysisImpl.java

💤 Files with no reviewable changes (1)

• nullaway/src/main/java/com/uber/nullaway/dataflow/RunOnceForwardAnalysisImpl.java

🧰 Additional context used

🧠 Learnings (3)

📓 Common learnings

Learnt from: msridhar
Repo: uber/NullAway PR: 1248
File: nullaway/src/main/java/com/uber/nullaway/generics/GenericsChecks.java:847-857
Timestamp: 2025-08-28T04:54:20.953Z
Learning: In NullAway's GenericsChecks.java, NewClassTree support for explicit type argument substitution requires more extensive changes beyond just modifying the conditional in compareGenericTypeParameterNullabilityForCall. The maintainers prefer to handle NewClassTree support in a separate follow-up rather than expanding the scope of PRs focused on specific issues like super constructor calls.

📚 Learning: 2025-08-29T18:41:43.584Z

Learnt from: msridhar
Repo: uber/NullAway PR: 1259
File: jdk-recent-unit-tests/src/test/java/com/uber/nullaway/jdk17/SwitchTests.java:318-321
Timestamp: 2025-08-29T18:41:43.584Z
Learning: Classes annotated with NullMarked are analyzed by NullAway even if they are not in packages specified by the AnnotatedPackages configuration. The NullMarked annotation guarantees NullAway analysis.

Applied to files:

• nullaway/src/main/java/com/uber/nullaway/dataflow/DataFlow.java

📚 Learning: 2025-08-14T18:50:06.159Z

Learnt from: msridhar
Repo: uber/NullAway PR: 1245
File: guava-recent-unit-tests/src/test/java/com/uber/nullaway/guava/NullAwayGuavaParametricNullnessTests.java:101-102
Timestamp: 2025-08-14T18:50:06.159Z
Learning: In NullAway JSpecify tests, when JDK version requirements exist due to bytecode annotation reading capabilities, prefer failing tests over skipping them on unsupported versions to ensure CI catches regressions and enforces proper JDK version usage for developers.

Applied to files:

• nullaway/src/main/java/com/uber/nullaway/dataflow/DataFlow.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: benchmarking
• GitHub Check: Build and test on ubuntu-latest
• GitHub Check: Build and test on macos-latest
• GitHub Check: Build spring-framework with snapshot
• GitHub Check: Build and test on windows-latest
• GitHub Check: Build caffeine with snapshot

🔇 Additional comments (2)

nullaway/src/main/java/com/uber/nullaway/dataflow/DataFlow.java (2)

44-44: LGTM!

The HashMap import is necessary for the updated Checker Framework API call at line 297.

---

297-297: The API usage is correct for Checker Framework 3.53.0.

The getStoreBefore method on Analysis objects in CF 3.53.0 accepts a Map parameter as a cache for storing per-node analysis results. Passing an empty HashMap is the correct approach here, as the analysis is being run in-progress and should not reuse a pre-existing cache. The signature differs from AnalysisResult.getStoreBefore(Tree) (which takes only the tree node), and both usages are correct for their respective types.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (9fb90c3) to head (ed1361b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1429      +/-   ##
============================================
+ Coverage     88.37%   88.45%   +0.08%     
+ Complexity     2667     2664       -3     
============================================
  Files            97       97              
  Lines          8853     8830      -23     
  Branches       1773     1767       -6     
============================================
- Hits           7824     7811      -13     
+ Misses          512      506       -6     
+ Partials        517      513       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Main Branch:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.442 ± 0.044  ops/s
CaffeineBenchmark.compile         thrpt   25   2.006 ± 0.014  ops/s
DFlowMicroBenchmark.compile       thrpt   25  40.996 ± 0.396  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.637 ± 0.017  ops/s

With This PR:

Benchmark                          Mode  Cnt   Score   Error  Units
AutodisposeBenchmark.compile      thrpt   25  10.497 ± 0.055  ops/s
CaffeineBenchmark.compile         thrpt   25   2.000 ± 0.010  ops/s
DFlowMicroBenchmark.compile       thrpt   25  41.021 ± 0.257  ops/s
NullawayReleaseBenchmark.compile  thrpt   25   1.646 ± 0.013  ops/s