JSpecify: improve inference for generic methods based on method reference arguments#1438
Merged
JSpecify: improve inference for generic methods based on method reference arguments#1438
Conversation
lazaroclapp
approved these changes
Feb 16, 2026
Collaborator
There was a problem hiding this comment.
Did another pass, minimal nits. I know I need to catch up to the changes that just came in, but this is starting to get to the point of complexity where I'd link issues for the remaining things and open separate PRs, personally 🙂
Edit: Never mind, I think the new changes were mostly the rebase, unless I am missing something.
This was referenced Mar 23, 2026
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now integrate inference of types for method references passed to generic method calls as part of the overall inference process for generic method calls. Includes handling of method references to varargs methods (which has a surprising number of corner cases).
Summary by CodeRabbit
Bug Fixes
Tests