Skip to content

Update comments in NullabilityUtil#hasAnyAnnotationMatching#1457

Merged
msridhar merged 1 commit intomasterfrom
update-comment
Jan 29, 2026
Merged

Update comments in NullabilityUtil#hasAnyAnnotationMatching#1457
msridhar merged 1 commit intomasterfrom
update-comment

Conversation

@msridhar
Copy link
Copy Markdown
Collaborator

@msridhar msridhar commented Jan 29, 2026

In #1452 we added a comment implying that change was needed due to a javac bug but that was incorrect; it was our bug that was being masked before. This PR fixes the comments (no behavior change).

Summary by CodeRabbit

  • Documentation
    • Improved internal code comments for clarity and maintainability.

✏️ Tip: You can customize this high-level summary in your review settings.

@msridhar msridhar requested a review from yuxincs January 29, 2026 21:28
@msridhar msridhar enabled auto-merge (squash) January 29, 2026 21:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 29, 2026

Walkthrough

This pull request updates comments in the hasAnyAnnotationMatching method of the NullabilityUtil class. A note is added before a loop that checks declaration annotations, and an existing comment is revised to clarify that the subsequent loop examines type-use annotations. The change involves two lines added and two lines removed, with no modifications to method logic, control flow, or signatures.

Possibly related PRs

  • PR #1362: Modifies the same hasAnyAnnotationMatching method with implementation changes, while this PR focuses on updating documentation comments

Suggested reviewers

  • yuxincs
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change—updating comments in NullabilityUtil#hasAnyAnnotationMatching—which aligns with the PR description and the file-level summary.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.41%. Comparing base (f3b9181) to head (b48d5b8).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1457   +/-   ##
=========================================
  Coverage     88.41%   88.41%           
  Complexity     2715     2715           
=========================================
  Files            99       99           
  Lines          9019     9019           
  Branches       1803     1803           
=========================================
  Hits           7974     7974           
  Misses          517      517           
  Partials        528      528           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msridhar msridhar merged commit 01f75fe into master Jan 29, 2026
12 checks passed
@msridhar msridhar deleted the update-comment branch January 29, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants