Skip to content

Better performance plotting script and readme updates #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikivazou merged 12 commits into from
Jun 9, 2023
Merged

Better performance plotting script and readme updates #2177

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3e2c3f0
minor refactor of benchmark-timings
clayrat May 31, 2023
70bc603
WIP plot-performance app
clayrat May 31, 2023
03daa84
WIP plot-perf: Chart dev for horizontal log bars
clayrat Jun 5, 2023
9c21bca
plot-perf refactor
clayrat Jun 5, 2023
74ac78c
syntax
clayrat Jun 5, 2023
962f842
update readme and gitignore
clayrat Jun 6, 2023
07ce10c
fix GHC.API link, update ghc verison in links
clayrat Jun 6, 2023
de2788f
Merge remote-tracking branch 'upstream/develop' into plot-performance
clayrat Jun 6, 2023
3850e1d
print filenames
clayrat Jun 7, 2023
6a43d8a
decide chart height from dataset size, print dims
clayrat Jun 8, 2023
aac5c51
make -o optional, create outdir is missing
clayrat Jun 8, 2023
32de722
use upstream haskell-chart
clayrat Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix GHC.API link, update ghc verison in links
  • Loading branch information
@clayrat
clayrat committed Jun 6, 2023
commit 07ce10c66a1e26e3f0f3cf5d4421c35e9882300e
14 changes: 6 additions & 8 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,8 +358,6 @@ patter synonym to deal with changes in type constructors.
Currently, no. Only one version of GHC is supported and that is the one
that can be tested with `./scripts/test/test_plugin.sh`.

[GHC.API]: src-ghc/Liquid/GHC/API.hs

# GHC Plugin Development FAQs

## Why is the GHC.Interface using slightly different types than the GHC.Plugin module?
Expand All @@ -371,23 +369,23 @@ to map back and forth (sometimes in a partial way) between old and new data stru
**consider the GHC.Plugin as the single source of truth, and prefer whichever data structure the latter is
using**.


[GHC.API]: liquidhaskell-boot/src-ghc/Liquid/GHC/API.hs
[Plugin]: liquidhaskell-boot/src/Language/Haskell/Liquid/GHC/Plugin.hs
[GHC.Plugin]: liquidhaskell-boot/src/Language/Haskell/Liquid/GHC/Plugin.hs
[GHC.Interface]: liquidhaskell-boot/src-ghc/Liquid/GHC/Interface.hs
[SpecFinder]: liquidhaskell-boot/src/Language/Haskell/Liquid/GHC/Plugin/SpecFinder.hs
[BareSpec]: liquidhaskell-boot/src/Language/Haskell/Liquid/Types/Specs.hs#L362
[LiftedSpec]: liquidhaskell-boot/src/Language/Haskell/Liquid/Types/Specs.hs#L559
[TargetSrc]: liquidhaskell-boot/src/Language/Haskell/Liquid/Types/Specs.hs#L158
[Ghc monad]: https://hackage.haskell.org/package/ghc-8.10.1/docs/GHC.html#t:Ghc
[HscEnv]: https://hackage.haskell.org/package/ghc-8.10.1/docs/GHC.html#t:HscEnv
[DynFlags]: https://hackage.haskell.org/package/ghc-8.10.1/docs/GHC.html#t:DynFlags
[GhcMonad]: https://hackage.haskell.org/package/ghc-8.10.1/docs/GHC.html#t:GhcMonad
[Ghc monad]: https://hackage.haskell.org/package/ghc-9.2.5/docs/GHC.html#t:Ghc
[HscEnv]: https://hackage.haskell.org/package/ghc-9.2.5/docs/GHC.html#t:HscEnv
[DynFlags]: https://hackage.haskell.org/package/ghc-9.2.5/docs/GHC.html#t:DynFlags
[GhcMonad]: https://hackage.haskell.org/package/ghc-9.2.5/docs/GHC.html#t:GhcMonad
[GhcMonadLike]: liquidhaskell-boot/src-ghc/Liquid/GHC/GhcMonadLike.hs
[typechecking phase]: liquidhaskell-boot/src/Language/Haskell/Liquid/GHC/Plugin.hs#L211-L226
[ghcide]: https://github.com/haskell/ghcide
[findRelevantSpecs]: liquidhaskell-boot/src/Language/Haskell/Liquid/GHC/Plugin/SpecFinder.hs#L65
[core binds]: https://hackage.haskell.org/package/ghc-8.10.1/docs/CoreSyn.html#t:CoreBind
[core binds]: https://hackage.haskell.org/package/ghc-9.2.5/docs/CoreSyn.html#t:CoreBind
[configureGhcTargets]: liquidhaskell-boot/src-ghc/Liquid/GHC/Interface.hs#L254
[processTargetModule]: liquidhaskell-boot/src-ghc/Liquid/GHC/Interface.hs#L483
[processModule]: liquidhaskell-boot/src/Language/Haskell/Liquid/GHC/Plugin.hs#L509
Expand Down