Skip to content

Update torch_utils.py #13682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
surely-you-cannot-be-sirius wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −3
Open

Update torch_utils.py #13682

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ee918c
Update torch_utils.py
surely-you-cannot-be-sirius Nov 14, 2025
9d01618
Update torch_utils.py
surely-you-cannot-be-sirius Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions utils/torch_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,7 @@ def select_device(device="", batch_size=0, newline=True):
device = str(device).strip().lower().replace("cuda:", "").replace("none", "") # to string, 'cuda:0' to '0'
cpu = device == "cpu"
mps = device == "mps" # Apple Metal Performance Shaders (MPS)
if cpu or mps:
os.environ["CUDA_VISIBLE_DEVICES"] = "-1" # force torch.cuda.is_available() = False
Comment on lines -118 to -119
Copy link
Member

@UltralyticsAssistant UltralyticsAssistant Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 MEDIUM: Removing the CUDA_VISIBLE_DEVICES='-1' assignment for cpu/mps makes select_device('cpu') and select_device('mps') no longer guarantee that CUDA is effectively disabled for the current process. Any existing callers that relied on select_device('cpu') to force torch.cuda.is_available() to be False (or to prevent accidental CUDA usage by downstream libs) will now see different behavior. It would be good to double‑check call sites, update any docstrings/comments that describe this behavior, and consider adding a small test to lock in the new contract so this change is intentional and well‑documented.

elif device: # non-cpu device requested
if device and not cpu and not mps: # non-cpu device requested
os.environ["CUDA_VISIBLE_DEVICES"] = device # set environment variable - must be before assert is_available()
assert torch.cuda.is_available() and torch.cuda.device_count() >= len(device.replace(",", "")), (
f"Invalid CUDA '--device {device}' requested, use '--device cpu' or pass valid CUDA device(s)"
Expand Down