Skip to content

[RTM] Refactored ScrollableViewHelper to interface #635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RTM] Refactored ScrollableViewHelper to interface #635

wants to merge 1 commit into from

Conversation

@renaudcerrato
Copy link

@renaudcerrato renaudcerrato commented Jan 6, 2016

ScrollableViewHelper should be an interface for a cleaner API. Moreover, since SlidingUpPanelLayout is only interested to know if the scrollable view can scroll, the return value should be a boolean.

@renaudcerrato renaudcerrato mentioned this pull request Jan 6, 2016
Closed
@renaudcerrato
Copy link
Author

renaudcerrato commented Jan 6, 2016

I'm closing because of a more elegant solution (#636)

@renaudcerrato renaudcerrato deleted the move_scrollable_view_helper_to_interface branch January 6, 2016 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@renaudcerrato