-
-
Notifications
You must be signed in to change notification settings - Fork 55
chore: migrate stable-hash
to stable-hash-x
#373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 74ca0f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThe updates consist of dependency version bumps, migration from Changes
Possibly related PRs
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
src/utils/export-map.tsOops! Something went wrong! :( ESLint: 9.28.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/lib/index.js' imported from /eslint.config.js test/rules/no-named-as-default.spec.tsOops! Something went wrong! :( ESLint: 9.28.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/lib/index.js' imported from /eslint.config.js src/utils/resolve.tsOops! Something went wrong! :( ESLint: 9.28.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/lib/index.js' imported from /eslint.config.js 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (10)
🔇 Additional comments (19)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #373 +/- ##
=======================================
Coverage 96.04% 96.04%
=======================================
Files 95 95
Lines 4926 4931 +5
Branches 1849 1827 -22
=======================================
+ Hits 4731 4736 +5
Misses 194 194
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to f660985 in 51 minutes and 32 seconds. Click for details.
- Reviewed
250
lines of code in10
files - Skipped
2
files when reviewing. - Skipped posting
8
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/autofix.yml:19
- Draft comment:
Updated checkout action commit to v4.2.2. Confirm this pinning follows your security guidelines. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
2. .yarnrc.yml:10
- Draft comment:
Yarn release updated to 4.9.2; ensure all team members update their tools accordingly. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. package.json:80
- Draft comment:
Migrated dependency from 'stable-hash' to 'stable-hash-x'. Verify that the stableHash API remains fully compatible. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to verify compatibility of a dependency change, which is against the rules. It doesn't provide a specific suggestion or point out a specific issue.
4. package.json:90
- Draft comment:
Several dependency version bumps (e.g., @typescript-eslint/*, eslint, jest) are introduced. Verify compatibility with your codebase. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
5. src/utils/export-map.ts:9
- Draft comment:
Import now uses 'stable-hash-x'. Ensure the stableHash function behaves identically to the old package. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the author to ensure that the new package behaves identically to the old one. This falls under asking the author to double-check things, which is against the rules.
6. src/utils/resolve.ts:6
- Draft comment:
Updated import to use 'stable-hash-x'. Confirm that its API and performance characteristics match expectations. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the PR author to confirm the API and performance characteristics of a dependency, which is not allowed according to the rules. It does not provide a specific code suggestion or ask for a specific test to be written.
7. test/__snapshots__/node-resolver.spec.ts.snap:60
- Draft comment:
Snapshot now shows jest module path as index.js (not index.mjs). Confirm that this change is intended. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. test/rules/no-named-as-default.spec.ts:165
- Draft comment:
Invalid test updated to use 'eslint-plugin-import-x' as the imported module. Confirm that the error ('ImportDefaultSpecifier') is correctly triggered. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the author to confirm that an error is correctly triggered, which violates the rule against asking the author to confirm their intention or ensure behavior. It does not provide a specific suggestion or ask for a specific test to be written.
Workflow ID: wflow_n5sVROVFxNwPL4CJ
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Summary by CodeRabbit
stable-hash
package tostable-hash-x
.Important
Migrate from
stable-hash
tostable-hash-x
across dependencies, source code, workflows, and tests.stable-hash
withstable-hash-x
inpackage.json
dependencies.package.json
.stable-hash
tostable-hash-x
inexport-map.ts
andresolve.ts
.actions/checkout
version comment tov4.2.2
inautofix.yml
,ci.yml
,pkg-pr-new.yml
, andrelease.yml
.yarnPath
toyarn-4.9.2.cjs
in.yarnrc.yml
.node-resolver.spec.ts.snap
to reflect changes in Jest path resolution.no-named-as-default.spec.ts
to useeslint-plugin-import-x
.This description was created by
for f660985. You can customize this summary. It will automatically update as commits are pushed.