-
Notifications
You must be signed in to change notification settings - Fork 235
Add minimal code to get it to work in the browser (chromium) #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this only requires to `npm install connect` and allow for TermKit to work in the browser
|
That would be great, maybe this deserves a separate project, it would be great TermKit could be used as a remote client |
|
SSH-in-the-browser-like? |
|
Exactly!, I know TermKit is not intended to be that, but maybe TermKit could be used to build something like that... |
|
the HTTP based user interface is very common pattern for node.js apps because no bindings to native GUIs are available yet (or not seriously usable). However given the latency I get when running it on localhost, I cannot begin to imagine how frustrating it would be to use it remotely. This patch is mainly intended to be able to run TermKit on other OS's than MacOS X (in my case, Ubuntu). Besides, I pulled from the repository today and I have trouble running a simple |
|
@hemna glad it worked. I forgot to ask for your node version, I assumed it was the latest, sorry. (by the way, last stable release is 0.4.7) I should consider doing a serious fork of this, unconed seems to be ignoring my pull request :/ |
|
I'm not getting icons with this. This makes me sad :( Great concept, and I'm glad to see it mostly working on Linux. |
|
@dhasenan I know, it's because icons use inline CSS and webkit-specific URIs. I have not worked out a solution for this at the moment. |
|
Is there any opportunity to use Curl or Wget instead of Get? Ubuntu and other Linux Distributions usually don't have get. Ubuntu uses Wget as Standard. |
|
This works already pretty good. What to do if TermKit loses keyboard focus? I can't get it to accept any keystrokes after I switched away from the browser tab in which it runs. Ubuntu 10.10, Chrome 11 |
|
Is this a bug, that chromium 13 output each time the content-type from not built in Applications? Content-Type: application/octet-stream |
|
So, I wrote a little Programm launcher for TermKit http://www.heypasteit.com/clip/YBB. you can change the chromium-browser by replacing it with chrome. I hope you enjoy it. |
|
Cool, I never had much interest for this Gnome stuff, glad to see someone knows it better. should read the rest seems ok to me, but again I'm no expert at this. |
|
@Floby: both should work: |
|
No, both don't work. When you navigate to a local html file (using file:// as protocol in chrome) WebSockets don't work. I was ready to believe otherwise, but doing so logs an error |
|
Why it Works for me? -- http://localhost:2222/ don't works for me |
|
@check probably because I committed further changes on my master branch so that socket.IO doesn't have it's localhost:2222 target hardcoded (allowing for remote use). But when you load the index.html as a file, it can't find where it should connect. @Shifty0x88 You should try and send me pull request =) this isn't very hard and I promise you'll have fun :D see github help |
|
@Shifty0x88 not the best way to do this, with this way you've alwas have the same icon. |
|
this is what the mime module is used for. You can use it from node.js On 21 May 2011 21:58, check <
|
|
@Floby: do you know why this happens? |
|
Oh that, no I haven't figured that out yet. Nice I'm glad to see you got the On May 21, 2011 6:49 PM, "check" <
|
|
@Shifty0x88: actully icons not work as good as possible. I made a php skript, but i think it gonna work better. The php skript use the icons of Faenza. http://paste.bradleygill.com/index.php?paste_id=289746 .. but i still working on this. |
|
Hey its better then no icons or what I had done just a file icon. Still had On May 21, 2011 7:16 PM, "check" <
|
|
Nice although its a shame we had to add the extra icons to it, and not use On May 21, 2011 7:57 PM, "check" <
|
|
I just started a linux client for TermKit, using gnome seed flamework, which is a javascript binding to libwebkit. I have not any previous experience with gtk, so , may someone can help me make it better? |
|
You're a Java/C++ programmer, right? Please don't write Java in Javascript. Don't do getters and setters -- they're just about the most stupid things in programming I've ever seen. |
|
FYI, the icons being chopped up across columns is a WebKit issue. They don't allow you to control column breaking inside elements yet. |
|
Oy. And I used the recursive option too. This is on ubuntu 11.10 with and sneilan@sneilan-ubuntu:~/build/TermKitProj/TermKit$ node Node/nodekit.js |
|
Which version of Node are you using? From the error message it looks like require.paths() is no longer valid. Seems like they removed the require.paths() function. Check out http://nodejs.org/docs/v0.4.3/api/all.html#loading_from_the_require.paths_Folders for some tips to fix the issue. I have all but given up on the project from the amount of JS code, and how I hate JS programming as it is not very static and everyone seems to have a different style. Was thinking about making a C clone of this, but I gave up. Check out Floby's (which I based my off of) or go back to the parent fork of Unconed for more information. Oh and a little google on: "Error: require.paths is removed. Use node_modules folders, or the NODE_PATH environment variable instead." will give you a bunch of hits from other GitHub projects that are using Node.js Sorry I am not much help... but good luck. -- Rob (Shifty0x88) |
Hello,
I wanted to try TermKit but I don't own any Mac (and probably never will) and run an Ubuntu instead =) so I modified some bits in your code to get it to work in Chromium which is based on webkit.
I have not looked closely at the icons not displaying but I reckon I can find a way to serve them through HTTP as well.
I'm sure you've considered these things before so I wouldn't be surprised if you didn't pull my request. But you never know, maybe I can help. This is a cool project.