fix #10
Merged
fix #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grace-uncountable
approved these changes
Jul 16, 2025
grace-uncountable
left a comment
grace-uncountable
left a comment
There was a problem hiding this comment.
Changes look good. I checked that this was a direct revert besides the changes to the playground. Thanks for working on this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #8
Katie and I did an investigation and found this PR was never merged: https://github.com/uncountableinc/main/pull/20141 which was supposed to install these changes.
Instead, Brendan implemented the fix in the main repo here: https://github.com/uncountableinc/main/pull/20148
So this code was never in use, and is causing issues in my upgrade here: https://github.com/uncountableinc/main/pull/66283
So I want to revert the bad code that was never used