containsColumn throws ArrayIndexOutOfBoundsException, in combination with selectFields

[mickaeltr]

Hello,

It seems that containsColumn throws an ArrayIndexOutOfBoundsException, when used in combination with selectFields. The following test fails because of that:

import com.univocity.parsers.csv.CsvParser;
import com.univocity.parsers.csv.CsvParserSettings;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

import java.io.ByteArrayInputStream;

class CsvParserTest {

  @Test
  void testContainColumns() {
    var settings = new CsvParserSettings();
    settings.setHeaderExtractionEnabled(true);
    settings.selectFields("AAA", "BBB", "CCC");
    var parser = new CsvParser(settings);
    var inputStream = new ByteArrayInputStream("AAA,BBB\na,b".getBytes());
    parser.beginParsing(inputStream);
    Assertions.assertFalse(parser.getRecordMetadata().containsColumn("CCC"));
  }

}

java.lang.ArrayIndexOutOfBoundsException: Index -1 out of bounds for length 2

	at com.univocity.parsers.common.ColumnMap.indexOf(ColumnMap.java:69)
	at com.univocity.parsers.common.DefaultContext.indexOf(DefaultContext.java:82)
	at com.univocity.parsers.common.record.RecordMetaDataImpl.containsColumn(RecordMetaDataImpl.java:481)

Thanks

[jbax]

Thanks for reporting this bug. I've fixed it and released a 2.8.2-SNAPSHOT build which should work as expected.

Thank you for using our parsers!

[mickaeltr]

Hi @jbax, thanks for fixing it so fast. Would that be an option to release 2.8.2 so I could cleanup my code?

try {
  return !csvParser.getRecordMetadata().containsColumn(fieldName);
} catch (ArrayIndexOutOfBoundsException e) {
  // Workaround for bug https://github.com/uniVocity/univocity-parsers/issues/316
  // Should be fixed in univocity-parsers 2.8.2
  return true;
}

[jbax]

No problem I'll try to this later today after I fix a few other issues

…

On Tue, 14 May 2019, 6:13 am Mickaël Tricot, ***@***.***> wrote: Hi @jbax <https://github.com/jbax>, thanks for fixing it so fast. Would that be an option to release 2.8.2 so I could cleanup my code? try { return !csvParser.getRecordMetadata().containsColumn(fieldName); } catch (ArrayIndexOutOfBoundsException e) { // Workaround for bug #316 // Should be fixed in univocity-parsers 2.8.2 return true; } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#316?email_source=notifications&email_token=ABWFQPVJK7FRBKFS4OS5E63PVJ7DBA5CNFSM4G4WTCSKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVK3ITY#issuecomment-492155983>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABWFQPT7XLGVOWEY5PLVFX3PVJ7DBANCNFSM4G4WTCSA> .