Skip to content

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

  • Code is formatted using Prettier, except markdown files.
  • JavaScript code is linted using XO.
  • Markdown is checked using remark-preset-wooorm.
  • GitHub actions is used to validate tests and code quality.
  • No package-lock.json file is generated.
  • Dependency version ranges of the form ^x.0.0 are used.

Many configurations have been copy-pasted from unified.

This is an initial step to start enhancing unified-language-server.

  • A broken test has been skipped.
  • Due to the synchronous nature, CJS is still used.
  • TypeScript checks aren’t implemented yet.
  • Code coverage hasn’t been implemented yet.

- Code is formatted using Prettier, except markdown files.
- JavaScript code is linted using XO.
- Markdown is checked using remark-preset-wooorm.
- GitHub actions is used to validate tests and code quality.
- No package-lock.json file is generated.
- Dependency version ranges of the form ^x.0.0 are used.

Many configurations have been copy-pasted from unified.

This is an initial step to start enhancing unified-language-server.

- A broken test has been skipped.
- Due to the synchronous nature, CJS is still used.
- TypeScript checks aren’t implemented yet.
- Code coverage hasn’t been implemented yet.
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remcohaszing!

Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I didn’t check every line as it’s a lot and I assume it’s good. Do share if there’s anthing in particular that you want to be reviewed.

@remcohaszing
Copy link
Member Author

I think the most important thing to review is that it still works.

I verified this manually by using it with vim-lsp before and after these changes.

@wooorm
Copy link
Member

wooorm commented Dec 7, 2021

I haven’t used this before, so I can’t help there, but 👍 on how you checked it

@wooorm
Copy link
Member

wooorm commented Dec 7, 2021

Good to go I think?

@remcohaszing
Copy link
Member Author

Yep, this is ready to go.

@wooorm wooorm merged commit 1c2e147 into unifiedjs:main Dec 8, 2021
@wooorm
Copy link
Member

wooorm commented Dec 8, 2021

Landed!

@remcohaszing remcohaszing deleted the unified-codequality-standards branch March 13, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants