Skip to content

Add support for VS Code Quick Fixes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 30, 2021
Merged

Add support for VS Code Quick Fixes #17

merged 2 commits into from
Dec 30, 2021

Conversation

remcohaszing
Copy link
Member

@remcohaszing remcohaszing commented Dec 29, 2021 •
edited
Loading

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This implements manual quick fixes (not to be confused with auto fixes!) by replacing the reported range with values taken from the expected array on vfile messages.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Dec 29, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@remcohaszing
Copy link
Member Author

I tested this manually in VS Code. It works pretty well. I wanted to add a screencast, but my screencast tool is broken. :(

@wooorm wooorm changed the title Implement quick fixes Add support for VS Code Quick Fixes Dec 29, 2021
wooorm
wooorm requested changes Dec 29, 2021
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. At some point it might be good to start documenting what is supported?

wooorm
wooorm approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. At some point it might be good to start documenting what is supported?

@remcohaszing

This comment has been minimized.

Sign in to view
@wooorm wooorm merged commit c777812 into unifiedjs:main Dec 30, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Dec 30, 2021
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Dec 30, 2021
@wooorm
Copy link
Member

wooorm commented Dec 30, 2021

Released!

@wooorm wooorm added 🗄 area/interface This affects the public interface 🦋 type/enhancement This is great to have 🧒 semver/minor This is backwards-compatible change labels Dec 30, 2021
@remcohaszing remcohaszing deleted the quick-fixes branch March 13, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remcohaszing @codecov-commenter @wooorm