Fix workspace initialization #27
Conversation
Without this fix, the error `Unhandled method client/registerCapability` is thrown when this server is started using `vscode-remark`. The fix was to move `connection.workspace.onDidChangeWorkspaceFolders()` into `connection.onInitialized()`. The initialize result is now also dynamic based on the reported server capabilities. This setup is based on https://code.visualstudio.com/api/language-extensions/language-server-extension-guide#explaining-the-language-server
github-actions
bot
added
👋 phase/new
remcohaszing
added
🐛 type/bug
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The CI failure seems to be unrelated 🤔 |
|
I noticed a windows error on xdm earlier today that is the same as what I see here. I don’t think it’s related either, no clue why it happens or what can solve it, it seems like a gitHub thing |
|
I hate to say it, but it works on my machine! Should I just increase the delays? |
|
@remcohaszing yup, this seems to work |
|
It remains that Windows fails on CI. I’m guessing it’s a GH Actions + Windows problem? |
This comment has been minimized.
This comment has been minimized.
|
@remcohaszing Are you planning on doing more work in this project? If so, I can delay a release and batch updates together. |
|
This change is really important in order to fix remarkjs/vscode-remark#65, but I can fix #26 first (probably later today) as it’s pretty straightforward. The other open issues are more meta issues that don’t require a release. |
Initial checklist
Description of changes
Without this fix, the error
Unhandled method client/registerCapabilityis thrown when this server is started usingvscode-remark.The fix was to move
connection.workspace.onDidChangeWorkspaceFolders()intoconnection.onInitialized(). The initialize result is now also dynamic based on the reported server capabilities. This setup is based on https://code.visualstudio.com/api/language-extensions/language-server-extension-guide#explaining-the-language-server.