Skip to content

Conversation

@remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

This allows us to use the console, which is useful for debugging.

This also simplifies how paths are resolved in tests. I combined these changes, because they touch the same lines.

This allows us to use the console, which is useful for debugging.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 9, 2022
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Looks like this fails on windows
  • Can you clarify how the console can be used?
  • Otherwise fine

@remcohaszing
Copy link
Member Author

Can you clarify how the console can be used?

stdout and stderr are now inherited from the parent process. It’s not used by the language client anymore. This means you can just write anything using console.log(), console.dir(), or whatever you like in the test and it will show up in the terminal.

@wooorm wooorm changed the title Use the node-ipc protocol for tests Refactor to use node-ipc protocol in tests Aug 14, 2022
@wooorm wooorm merged commit 4380a0f into unifiedjs:main Aug 14, 2022
@wooorm wooorm added 🕸️ area/tests This affects tests 💪 phase/solved Post is done labels Aug 14, 2022
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 14, 2022
@remcohaszing remcohaszing deleted the tests-node-ipc branch August 14, 2022 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🕸️ area/tests This affects tests 💪 phase/solved Post is done

Development

Successfully merging this pull request may close these issues.

2 participants