Skip to content

Conversation

@remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Killing a child process prevents Node.js from collecting code coverage. The language server process can be stopped gracefully when using stdio, but not when using ipc.

Killing a child process prevents Node.js from collecting code coverage.
The language server process can be stopped gracefully when using stdio,
but not when using ipc.
@remcohaszing remcohaszing added 🕸️ area/tests This affects tests 🤞 phase/open Post is being triaged manually labels Aug 22, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +100.00% 🎉

Comparison is base (752400a) 0.00% compared to head (56cfe09) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           main       #61        +/-   ##
===========================================
+ Coverage      0   100.00%   +100.00%     
===========================================
  Files         0         2         +2     
  Lines         0       474       +474     
===========================================
+ Hits          0       474       +474     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remcohaszing remcohaszing merged commit dd63b00 into unifiedjs:main Aug 22, 2023
@remcohaszing remcohaszing deleted the fix-coverage branch August 22, 2023 13:02
@github-actions

This comment has been minimized.

@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Aug 22, 2023
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🕸️ area/tests This affects tests 💪 phase/solved Post is done

Development

Successfully merging this pull request may close these issues.

2 participants