Skip to content

types: add support for boolean plugin options #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2021
Merged

types: add support for boolean plugin options #145

merged 1 commit into from
Jul 4, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Jul 4, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

.use can be called with true or false to turn plugins on or off

@wooorm wooorm added the ☂️ area/types This affects typings label Jul 4, 2021
@wooorm wooorm requested a review from ChristianMurphy July 4, 2021 12:03
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 4, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
ChristianMurphy
ChristianMurphy reviewed Jul 4, 2021
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions:

  1. is this only for plugins? Or can it also apply to compiler, parser, and/or settings options?
  2. Is this mostly to support remark-lint? Would it make sense to get typings in place there as an alternative?

@wooorm
Copy link
Member Author

wooorm commented Jul 4, 2021

  1. Plugins:

    unified/index.js

    Lines 108 to 114 in 45eb72e

    if (values[1] === false) {
    continue
    }
    if (values[1] === true) {
    values[1] = undefined
    }
  2. unified-engine, but yes, also remark-lint

@wooorm wooorm added the 💪 phase/solved Post is done label Jul 4, 2021
@wooorm wooorm merged commit 4bfd6c8 into main Jul 4, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 4, 2021
@wooorm wooorm deleted the boolean-options branch July 4, 2021 15:20
@github-actions
Copy link

github-actions bot commented Jul 4, 2021

Hi! This was closed. Team: If this was merged, please describe when this is likely to be released. Otherwise, please add one of the no/* labels.

wooorm
wooorm commented Jul 4, 2021
View reviewed changes
@ChristianMurphy ChristianMurphy mentioned this pull request Jul 6, 2021
Merged
5 tasks
wooorm pushed a commit that referenced this pull request Jul 6, 2021
@ChristianMurphy
Fix types to support booleans
b8fe5ec 
Related to GH-145.
Closes GH-147.

Reviewed-by: Titus Wormer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wooorm @codecov-commenter @ChristianMurphy