Add request retry mechanism #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chita13
requested changes
Aug 4, 2022
Collaborator
chita13
left a comment
chita13
left a comment
There was a problem hiding this comment.
Open issues:
- how to test it, let's investigate a little bit on how we can mock the response in order to check the retry mechanism.. I used in the past this but let's check what works for us :)
- idempotency issue - I will return to you about it
and added idempotency_key_is_not_present check
chita13
requested changes
Sep 7, 2022
- added post_create function for create requests with idempotency_key - backoff_idempotency_key_handler
chita13
reviewed
Sep 29, 2022
chita13
approved these changes
Oct 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#133 - https://docs.unit.co/#retries
added backoff library to perform retry on requests when needed
the default retries is 0