jwtSubject to jwtToken #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsafPolakovski
approved these changes
Oct 12, 2022
rolycg
reviewed
Oct 14, 2022
| def test_create_jwt_token(): | ||
| account_id = create_individual_customer() | ||
| request = CreateCustomerToken(account_id, "customers accounts", | ||
| jwt_subject="eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9fQ") |
There was a problem hiding this comment.
Is jwt_subject and jwt_token the same field? What is the diff between these 2 fields?
There was a problem hiding this comment.
No, they are not the same, you understood correctly it should be the token.
the jwt_subject should be set for the customer in order to identify that the token sent is related to the specific customer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#161