Skip to content
Merged
Prev Previous commit
PY-benOff-fields removing BillPayments
  • Loading branch information
stymoshchuk committed Aug 1, 2024
commit 37747b1973f5229d02539c02a5da89e8e3a6fe26
21 changes: 0 additions & 21 deletions e2e_tests/bill_pay_test.py

This file was deleted.

2 changes: 0 additions & 2 deletions unit/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from unit.api.webhook_resource import WebhookResource
from unit.api.institution_resource import InstitutionResource
from unit.api.atmLocation_resource import AtmLocationResource
from unit.api.bill_pay_resource import BillPayResource
from unit.api.api_token_resource import APITokenResource
from unit.api.authorization_resource import AuthorizationResource
from unit.api.authorization_request_resource import AuthorizationRequestResource
Expand Down Expand Up @@ -57,7 +56,6 @@ def __init__(self, api_url=None, token=None, retries=0, timeout=120, configurati
self.webhooks = WebhookResource(c)
self.institutions = InstitutionResource(c)
self.atmLocations = AtmLocationResource(c)
self.billPays = BillPayResource(c)
self.api_tokens = APITokenResource(c)
self.authorizations = AuthorizationResource(c)
self.authorization_requests = AuthorizationRequestResource(c)
Expand Down
22 changes: 0 additions & 22 deletions unit/api/bill_pay_resource.py

This file was deleted.

21 changes: 0 additions & 21 deletions unit/models/bill_pay.py

This file was deleted.

9 changes: 1 addition & 8 deletions unit/models/codecs.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from unit.models.repayment import BookRepaymentDTO, AchRepaymentDTO
from unit.models.tax_form import TaxFormDTO
from unit.models.transaction import transactions_mapper, ReturnedCheckPaymentTransactionDTO, CheckPaymentTransactionDTO
from unit.models.payment import AchPaymentDTO, BookPaymentDTO, WirePaymentDTO, BillPaymentDTO, AchReceivedPaymentDTO, \
from unit.models.payment import AchPaymentDTO, BookPaymentDTO, WirePaymentDTO, AchReceivedPaymentDTO, \
RecurringCreditAchPaymentDTO, RecurringCreditBookPaymentDTO, RecurringDebitAchPaymentDTO, BulkPaymentsDTO
from unit.models.customerToken import CustomerTokenDTO, CustomerVerificationTokenDTO
from unit.models.fee import FeeDTO
Expand All @@ -28,7 +28,6 @@
from unit.models.institution import InstitutionDTO
from unit.models.statement import StatementDTO
from unit.models.atm_location import AtmLocationDTO
from unit.models.bill_pay import BillerDTO
from unit.models.api_token import APITokenDTO
from unit.models.authorization import AuthorizationDTO
from unit.models.authorization_request import PurchaseAuthorizationRequestDTO, CardTransactionAuthorizationRequestDTO, \
Expand Down Expand Up @@ -96,9 +95,6 @@
"wirePayment": lambda _id, _type, attributes, relationships:
WirePaymentDTO.from_json_api(_id, _type, attributes, relationships),

"billPayment": lambda _id, _type, attributes, relationships:
BillPaymentDTO.from_json_api(_id, _type, attributes, relationships),

"achReceivedPayment": lambda _id, _type, attributes, relationships:
AchReceivedPaymentDTO.from_json_api(_id, _type, attributes, relationships),

Expand Down Expand Up @@ -144,9 +140,6 @@
"atmLocation": lambda _id, _type, attributes, relationships:
AtmLocationDTO.from_json_api(_type, attributes),

"biller": lambda _id, _type, attributes, relationships:
BillerDTO.from_json_api(_id, _type, attributes, relationships),

"apiToken": lambda _id, _type, attributes, relationships:
APITokenDTO.from_json_api(_id, _type, attributes, relationships),

Expand Down
19 changes: 2 additions & 17 deletions unit/models/payment.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from unit.models import *
from unit.models.check_payment import CheckPaymentCounterparty

PaymentTypes = Literal["AchPayment", "BookPayment", "WirePayment", "BillPayment"]
PaymentTypes = Literal["AchPayment", "BookPayment", "WirePayment"]
PaymentDirections = Literal["Debit", "Credit"]
PaymentStatus = Literal["Pending", "Rejected", "Clearing", "Sent", "Canceled", "Returned"]
RecurringStatus = Literal["Active", "Completed", "Disabled"]
Expand Down Expand Up @@ -99,22 +99,7 @@ def from_json_api(_id, _type, attributes, relationships):
attributes["description"], attributes["amount"], attributes.get("reason"),
attributes.get("tags"), relationships)


class BillPaymentDTO(BasePayment):
def __init__(self, _id: str, created_at: datetime, status: PaymentStatus, direction: str, description: str,
amount: int, reason: Optional[str], tags: Optional[Dict[str, str]],
relationships: Optional[Dict[str, Relationship]]):
BasePayment.__init__(self, _id, created_at, status, direction, description, amount, reason, tags, relationships)
self.type = 'billPayment'

@staticmethod
def from_json_api(_id, _type, attributes, relationships):
return BillPaymentDTO(_id, date_utils.to_datetime(attributes["createdAt"]), attributes["status"],
attributes["direction"], attributes["description"], attributes["amount"],
attributes.get("reason"), attributes.get("tags"), relationships)


PaymentDTO = Union[AchPaymentDTO, BookPaymentDTO, WirePaymentDTO, BillPaymentDTO]
PaymentDTO = Union[AchPaymentDTO, BookPaymentDTO, WirePaymentDTO]

AchReceivedPaymentStatus = Literal["Pending", "Advanced", "Completed", "Returned"]

Expand Down