-
Notifications
You must be signed in to change notification settings - Fork 70
feat: hide author email address via flag #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The code here lgtm; although, it feels like this privacy-first option should be the default rather than opt-in |
pi0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Regarding privacy, emails are always persisted in git commits, we are not exposing that is not already public. Github allows |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
===========================================
- Coverage 69.10% 45.05% -24.06%
===========================================
Files 9 12 +3
Lines 916 950 +34
Branches 85 95 +10
===========================================
- Hits 633 428 -205
- Misses 283 519 +236
- Partials 0 3 +3 ☔ View full report in Codecov by Sentry. |
Add a new flag which allows to hide the email addresses for authors.
This PR resolves #246.