Skip to content

Conversation

@PKief
Copy link
Contributor

@PKief PKief commented Dec 11, 2024

Add a new flag which allows to hide the email addresses for authors.

This PR resolves #246.

@adamdehaven
Copy link

The code here lgtm; although, it feels like this privacy-first option should be the default rather than opt-in

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0
Copy link
Member

pi0 commented Feb 26, 2025

Regarding privacy, emails are always persisted in git commits, we are not exposing that is not already public.

Github allows <username>@users.noreply.github.com (or <id>+<username>@users.noreply.github.com when privacy enabled) to be used instead of real email.

@pi0 pi0 merged commit e1147e8 into unjs:main Feb 26, 2025
2 checks passed
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.05%. Comparing base (0914fd7) to head (d619a18).
Report is 55 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #247       +/-   ##
===========================================
- Coverage   69.10%   45.05%   -24.06%     
===========================================
  Files           9       12        +3     
  Lines         916      950       +34     
  Branches       85       95       +10     
===========================================
- Hits          633      428      -205     
- Misses        283      519      +236     
- Partials        0        3        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Optionally hide email addresses for authors

3 participants