Skip to content

Conversation

Simon-He95
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Nov 29, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @danielroe on Vercel.

@danielroe first needs to authorize it.

@what-the-diff
Copy link

what-the-diff bot commented Nov 29, 2022

  • The plugin now returns true if the file is a vue or js/ts file
  • If the node type isn't CallExpression, return early from enter() function
  • Check for normal call and namespaced call in one condition instead of two separate conditions

@vercel
Copy link

vercel bot commented Nov 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
magic-regexp ✅ Ready (Inspect) Visit Preview Nov 29, 2022 at 1:33PM (UTC)

@danielroe
Copy link
Member

It's always tricky, but these changes don't change the performance or functionality of the library. Subjectively, I prefer the current implementation as I think it's clearer and easier to follow.

@danielroe danielroe closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants