Skip to content

fix: fix issues with native node fetch #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 6, 2023
Merged

fix: fix issues with native node fetch #245

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c74a6e4
fix(fetch): use try-catch block to capture fetching errors
arunanshub Jun 5, 2023
0f4249d
test(index): keep the server alive during the entire test session
arunanshub Jun 5, 2023
22c30be
fix(fetch): await `onError` and use asnyc function syntax
arunanshub Jun 6, 2023
95cd14e
Merge branch 'main' into pr/arunanshub/245
pi0 Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(fetch): use try-catch block to capture fetching errors
  • Loading branch information
@arunanshub
arunanshub committed Jun 5, 2023
commit c74a6e43e3ea3c7e331ff9a8b2537d282e12f6cb
16 changes: 9 additions & 7 deletions src/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,16 +170,18 @@ export function createFetch(globalOptions: CreateFetchOptions): $Fetch {
}
}

context.response = await fetch(
context.request,
context.options as RequestInit
).catch(async (error) => {
context.error = error;
try {
context.response = await fetch(
context.request,
context.options as RequestInit
);
} catch (error) {
context.error = error as Error;
if (context.options.onRequestError) {
await context.options.onRequestError(context as any);
}
return onError(context);
});
return await onError(context);
}

const responseType =
(context.options.parseResponse ? "json" : context.options.responseType) ||
Expand Down