-
-
Notifications
You must be signed in to change notification settings - Fork 297
Migrate smart contracts extensions to hardhat #7503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
| ), | ||
| 'ONLY_LOCK_MANAGER.' | ||
| "VM Exception while processing transaction: reverted with reason string 'ONLY_LOCK_MANAGER'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing I dont get here is why this was throwing, when others reverts test were not, such as
unlock/smart-contract-extensions/test/keyPurchaser.js
Lines 44 to 52 in 065eb9e
| await reverts( | |
| keyPurchaser.readyToPurchaseFor(endUser, constants.ZERO_ADDRESS, []), | |
| 'INSUFFICIENT_ALLOWANCE' | |
| ) | |
| await reverts( | |
| keyPurchaser.purchaseFor(endUser, constants.ZERO_ADDRESS, [], { | |
| from: otherAccount, | |
| }) | |
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh well.
|
Nice! |
|
i think once merged we can trigger a rebase of #6870 |
|
ok will try the rebase then |
|
oh you can just click the checkbox :) |
|
oh great ! |
Description
Issues
Relates to discussion in #7446 about upgrading packages
Checklist: