Skip to content

Conversation

@clemsos
Copy link
Member

@clemsos clemsos commented Sep 3, 2021

Description

  • remove truffle
  • cleanup deps
  • fix tests

Issues

Relates to discussion in #7446 about upgrading packages

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@cla-bot cla-bot bot added the cla-signed label Sep 3, 2021
@clemsos clemsos requested a review from julien51 September 3, 2021 12:33
@clemsos clemsos mentioned this pull request Sep 3, 2021
}
),
'ONLY_LOCK_MANAGER.'
"VM Exception while processing transaction: reverted with reason string 'ONLY_LOCK_MANAGER'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing I dont get here is why this was throwing, when others reverts test were not, such as

await reverts(
keyPurchaser.readyToPurchaseFor(endUser, constants.ZERO_ADDRESS, []),
'INSUFFICIENT_ALLOWANCE'
)
await reverts(
keyPurchaser.purchaseFor(endUser, constants.ZERO_ADDRESS, [], {
from: otherAccount,
})
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well.

@julien51
Copy link
Member

julien51 commented Sep 3, 2021

Nice!

@julien51
Copy link
Member

julien51 commented Sep 3, 2021

i think once merged we can trigger a rebase of #6870

@clemsos clemsos merged commit a853647 into master Sep 3, 2021
@clemsos clemsos deleted the smart-contract-extensions-hardhat branch September 3, 2021 13:01
@clemsos
Copy link
Member Author

clemsos commented Sep 3, 2021

ok will try the rebase then

@julien51
Copy link
Member

julien51 commented Sep 3, 2021

oh you can just click the checkbox :)

@clemsos
Copy link
Member Author

clemsos commented Sep 3, 2021

oh great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants