Fix invalid code generation for multiple event handlers#502
Merged
jeromelaban merged 1 commit intomasterfrom Jan 17, 2019
Merged
Fix invalid code generation for multiple event handlers#502jeromelaban merged 1 commit intomasterfrom
jeromelaban merged 1 commit intomasterfrom
Conversation
jeromelaban
force-pushed
the
devjela/duplicate-xaml-events
branch
from
eac2e5c to
5018bc7
Compare
dr1rrb
approved these changes
Jan 17, 2019
jeromelaban
added a commit
to unoplatform/Uno.Windows-universal-samples
that referenced
this pull request
Jan 17, 2019
carldebilly
approved these changes
Jan 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What is the current behavior?
This code fails to compile
<Button Click="Button_Click" Loaded="OnLoadUnload" Unloaded="OnLoadUnload" />What is the new behavior?
The above code build properly. This regression was introduced by the #497.
PR Checklist
Please check if your PR fulfills the following requirements: