Skip to content

Simplified flag value access #1367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meatballhat merged 17 commits into from
May 1, 2022
Merged

Simplified flag value access #1367

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
baf8ae9
BoolFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
9eae255
DurationFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
5047beb
Float64Flag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
2f92fc6
Float64SliceFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
8bd5fb2
GenericFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
bf18c00
IntFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
18b44df
Int64Flag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
dcc4785
Int64SliceFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
6d7f859
IntSliceFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
660184d
PathFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
ce4d927
StringFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
6b336c4
StringSliceFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
889c7b5
TimestampFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
1f62105
UintFlag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
ca7f26e
Uint64Flag.ValueFromContext() as convenient accessor
toaster Apr 22, 2022
835bd32
rename flags’ ValueFromContext() to Get()
toaster Apr 25, 2022
8cc4378
Merge branch 'main' into feature/1316-simplified_flag_value_access
meatballhat Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into feature/1316-simplified_flag_value_access
  • Loading branch information
@meatballhat
meatballhat authored Apr 26, 2022
commit 8cc43782eda61b28f352d0dd1625d7fe93e80cfb
2 changes: 1 addition & 1 deletion flag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ func TestPathFlagValueFromContext(t *testing.T) {
expect(t, f.Get(ctx), "/my/path")
}

var envHintFlagTests = []struct {
var _ = []struct {
name string
env string
hinter FlagEnvHintFunc
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.