Skip to content

Conversation

@meatballhat
Copy link
Member

What type of PR is this?

  • bug
  • documentation

What this PR does / why we need it:

This change ensures the docs tests are run against the current work tree by creating a temporary go workspace to be used by gfmrun via TMPDIR.

Which issue(s) this PR fixes:

N/A 😬

by creating a temporary go workspace to be used by gfmrun via `TMPDIR`.
@meatballhat meatballhat added kind/bug describes or fixes a bug kind/documentation describes a documentation update area/v2 relates to / is being considered for v2 labels May 23, 2022
@meatballhat meatballhat added this to the Release 2.x milestone May 23, 2022
@meatballhat meatballhat marked this pull request as ready for review May 23, 2022 02:24
@meatballhat meatballhat requested a review from a team as a code owner May 23, 2022 02:24
mostynb
mostynb previously approved these changes May 23, 2022
and slightly revert assertion in docs test to ensure flag ordering
@meatballhat meatballhat merged commit 595cabc into main May 23, 2022
@meatballhat meatballhat deleted the gfmrun-current branch May 23, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/v2 relates to / is being considered for v2 kind/bug describes or fixes a bug kind/documentation describes a documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants