Remove GPL2 dependency introduced in v2.7.0 #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
CI failure seems irrelevant to the commit https://github.com/urfave/cli/runs/6567968972?check_suite_focus=true |
AkihiroSuda
force-pushed
the
remove-gpl2-dependency
branch
from
eee1066 to
805c7b2
Compare
This commit replaces github.com/antzucaro/matchr (GPL2, introduced in v2.7.0) with github.com/xrash/smetrics (MIT License). Fixes issue 1404 Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
remove-gpl2-dependency
branch
from
805c7b2 to
edb9cc4
Compare
Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
remove-gpl2-dependency
branch
from
edb9cc4 to
3e31c9b
Compare
dearchap
approved these changes
May 24, 2022
Member
|
@AkihiroSuda Thank you! |
3 tasks
This was referenced Mar 5, 2025
Open
Open
Closed
Open
This was referenced Mar 11, 2025
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Replaces https://github.com/antzucaro/matchr (GPL2, introduced in v2.7.0) with https://github.com/xrash/smetrics (MIT License).
This is needed because downstream projects may use GPL2-incompatible licenses such as Apache License 2.0.
Which issue(s) this PR fixes:
Fixes #1404
Release Notes