Fix: Make DefaultText behaviour consistent #2214
Merged
+18
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juneezee
approved these changes
Oct 21, 2025
Contributor
|
Hi @dearchap , related to since HideDefault is false by default then in this case it should show default value in this test |
1 task
saschazepter
pushed a commit
to saschazepter/forgejo
that referenced
this pull request
Oct 23, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | `v3.4.1` -> `v3.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.5.0`](https://github.com/urfave/cli/releases/tag/v3.5.0) [Compare Source](urfave/cli@v3.4.1...v3.5.0) #### What's Changed - Update mkdocs reqs by [@​meatballhat](https://github.com/meatballhat) in [#​2190](urfave/cli#2190) - Allow the user to stop processing flags after seeing N args by [@​adrian-thurston](https://github.com/adrian-thurston) in [#​2163](urfave/cli#2163) - chore(deps): bump github.com/stretchr/testify from 1.10.0 to 1.11.0 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2194](urfave/cli#2194) - chore(deps): bump mkdocs-material from 9.6.16 to 9.6.18 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2195](urfave/cli#2195) - chore(deps): bump actions/setup-go from 5 to 6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2198](urfave/cli#2198) - chore(deps): bump actions/setup-node from 4 to 5 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2199](urfave/cli#2199) - chore(deps): bump actions/setup-python from 5 to 6 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2200](urfave/cli#2200) - chore(deps): bump github.com/stretchr/testify from 1.11.0 to 1.11.1 by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2197](urfave/cli#2197) - chore(deps): bump mkdocs-material from 9.6.18 to 9.6.19 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2201](urfave/cli#2201) - chore(deps): bump mkdocs-material from 9.6.19 to 9.6.20 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2202](urfave/cli#2202) - feat: add name of argument into error message when parsing fails by [@​oprudkyi](https://github.com/oprudkyi) in [#​2203](urfave/cli#2203) - chore(deps): bump mkdocs-material from 9.6.20 to 9.6.21 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2204](urfave/cli#2204) - add space between arguments usage by [@​dimfu](https://github.com/dimfu) in [#​2207](urfave/cli#2207) - chore(deps): bump mkdocs-material from 9.6.21 to 9.6.22 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2213](urfave/cli#2213) - Fix: Make DefaultText behaviour consistent by [@​dearchap](https://github.com/dearchap) in [#​2214](urfave/cli#2214) #### New Contributors - [@​adrian-thurston](https://github.com/adrian-thurston) made their first contribution in [#​2163](urfave/cli#2163) - [@​oprudkyi](https://github.com/oprudkyi) made their first contribution in [#​2203](urfave/cli#2203) - [@​dimfu](https://github.com/dimfu) made their first contribution in [#​2207](urfave/cli#2207) **Full Changelog**: <urfave/cli@v3.4.1...v3.5.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNTIuOSIsInVwZGF0ZWRJblZlciI6IjQxLjE1Mi45IiwidGFyZ2V0QnJhbmNoIjoiZm9yZ2VqbyIsImxhYmVscyI6WyJkZXBlbmRlbmN5LXVwZ3JhZGUiLCJ0ZXN0L25vdC1uZWVkZWQiXX0=--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/9818 Reviewed-by: Earl Warren <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
Contributor
Author
|
@oprudkyi I think it doesnt make sense for bool flags to have default texts since they are false by default no ? |
Contributor
|
@dearchap yes, sure. Sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
The behaviour of GetDefaultText was too unpredictable, depending on whether the DefaultText is set or whether Value is set and what not. This change takes the guesswork out of flag_impl.go and puts the logic into docs.go where it should be
Which issue(s) this PR fixes:
(REQUIRED)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)
make test
Release Notes
(REQUIRED)