Skip to content

Suggest adding no_main for error[E0601] #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 16 commits into from
May 17, 2023
Merged

Suggest adding no_main for error[E0601] #1113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0c99407
Use duct to build/invoke cargo command
ascjones May 15, 2023
d7e488f
Push command to args
ascjones May 15, 2023
f1aa1ab
Ignore cargo tree stdout
ascjones May 15, 2023
4e58d09
Suggest adding `no_main`
ascjones May 15, 2023
3a595ad
Read one byte at a time to get the progress bar
ascjones May 16, 2023
c7ab397
Refactor to separate method
ascjones May 16, 2023
b5febf0
Update crates/build/src/lib.rs
ascjones May 16, 2023
9f7a0a4
Detect term size
ascjones May 17, 2023
a2505c3
Update suggestion and exit on error
ascjones May 17, 2023
bb5ac97
Update message
ascjones May 17, 2023
a746e57
Hardcode term size
ascjones May 17, 2023
e041261
Hardcode term size
ascjones May 17, 2023
b90369d
Only detect term size on non windows OS
ascjones May 17, 2023
b1f47a8
Red
ascjones May 17, 2023
483a2b6
Use term_size for windows
ascjones May 17, 2023
87d7f06
use term_size as _;
ascjones May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Detect term size
  • Loading branch information
@ascjones
ascjones committed May 17, 2023
commit 9f7a0a47105cf51d517b12fb0152199bb81b9889
11 changes: 11 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/build/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ semver = { version = "1.0.17", features = ["serde"] }
serde = { version = "1", default-features = false, features = ["derive"] }
serde_json = "1.0.96"
tempfile = "3.5.0"
term_size = "0.3.2"
url = { version = "2.3.1", features = ["serde"] }
wasm-opt = "0.112.0"
which = "4.4.0"
Expand Down
8 changes: 6 additions & 2 deletions crates/build/src/util/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@ where

/// Configures the cargo command to output colour and the progress bar.
pub fn cargo_tty_output(cmd: Expression) -> Expression {
cmd.env("CARGO_TERM_COLOR", "always")
.env("CARGO_TERM_PROGRESS_WIDTH", "100")
let term_size = term_size::dimensions_stderr()
.map(|(width, _)| width.to_string())
.unwrap_or_else(|| "100".to_string());
cmd
.env("CARGO_TERM_COLOR", "always")
.env("CARGO_TERM_PROGRESS_WIDTH", term_size)
.env("CARGO_TERM_PROGRESS_WHEN", "always")
}

Expand Down