Conversation
smiasojed
requested review from
SkymanOne,
ascjones and
cmichi
as code owners
ascjones
reviewed
Dec 20, 2023
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
WIP review, will finish when I return from Christmas!
ascjones
reviewed
Jan 8, 2024
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
Overall looks good. contract_storage.rs is starting to be quite a large file, so might benefit from breaking up files for different concerns e.g. fetching vs displaying the data.
Co-authored-by: Andrew Jones <ascjones@gmail.com>
ascjones
approved these changes
Jan 9, 2024
Collaborator
ascjones
left a comment
ascjones
left a comment
There was a problem hiding this comment.
LGTM. Can you add to CHANGELOG please?
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related #101
inkorpallet-contracts?Add a user-friendly view of contract storage data in the form of a table
Description
Example output:
Checklist before requesting a review
CHANGELOG.md