Run wasm-opt first, remove sign_ext feature#1416
Merged
Conversation
SkymanOne
approved these changes
Dec 1, 2023
Contributor
|
Merging on behalf of @ascjones |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parity-wasmcurrently requires thesign-extfeature in order to load aWasmmodule for validation containtingsign_extinstructions, otherwise we get theunknown opcode 192error. This feature can cause issues when combined with other crates which depend on it but don't handle that new instruction e.g.wasm-instrument(withoutsign-extenabled).However, in #1280 we use
SignExtLoweringto remove those instructions during optimization, to allow for compatibility with versions ofpallet_contractswhich do not yet support that instruction.This PR reverses the
optimizeandpost_processsteps so that optimization happens first, removing the instruction.Proof it works, building any contract in debug mode,
sign_extfeature removed, first with original order now with new order: