Skip to content

Fix bug with empty Wasm file when using system binaryen for optimization #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmichi merged 6 commits into from
Feb 18, 2021
Merged

Fix bug with empty Wasm file when using system binaryen for optimization #179

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
442573e
Revert me: Hotfix for funty issue
cmichi Feb 16, 2021
fb6bcfd
Assert that size of resulting wasm is > 0
cmichi Feb 18, 2021
de018df
Ensure optimized file is not overwritten with empty file on `not(feat…
cmichi Feb 18, 2021
1fceeb8
Fix `warning: panic message is not a string literal`
cmichi Feb 18, 2021
ab7468f
Do not record debug info
cmichi Feb 18, 2021
a27ea6e
Update comments
cmichi Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix warning: panic message is not a string literal
  • Loading branch information
@cmichi
cmichi committed Feb 18, 2021
commit 1fceeb8fbb61b0116a2dc9bb0fa3ffcb9b5190c5
3 changes: 2 additions & 1 deletion src/cmd/metadata.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,8 @@ mod tests {

assert!(
dest_bundle.exists(),
format!("Missing metadata file '{}'", dest_bundle.display())
"Missing metadata file '{}'",
dest_bundle.display()
);

let source = metadata_json.get("source").expect("source not found");
Expand Down