refactor(deps): update subxt and address breaking changes#2036
Merged
davidsemakula merged 8 commits intomasterfrom May 14, 2025
Merged
refactor(deps): update subxt and address breaking changes#2036davidsemakula merged 8 commits intomasterfrom
davidsemakula merged 8 commits intomasterfrom
Conversation
added 7 commits
May 14, 2025 07:11
evilrobot-01
commented
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As per use-ink/ink-alliance#42, updates subxt to the latest version, addressing breaking changes in the least intrusive way possible.
inkorpallet-contracts? Yes, it requires a version with the same subxt updates, which is currently available at build(deps): update subxt (and related deps) ink#2504. The dependencies will be updated once that PR is merged to conclude the completion of this PR.Description
The following breaking changes affected the codebase:
substrate-compatfeature in https://github.com/paritytech/subxt/releases/tag/v0.39.0. The ink crates now control the version ofsp-core/sp-runtimeas required.num-traitsdependency added forZerotrait access as an example.PairSignerin https://github.com/paritytech/subxt/releases/tag/v0.39.0, along with guidance in https://github.com/paritytech/subxt/blob/d924ece39a5cb369ba5ccde3dc160b5ee006271b/subxt/examples/substrate_compat_signer.rs. This resulted in the biggest breaking changes, which have been implemented in the lightest way possible (i.e. no additional deps introduced unnecessarily).Hashassociated type from theConfigtrait. Type alias provided to ease the transition.Checklist before requesting a review
CHANGELOG.md