Skip to content

chore: Upgrade to Rust edition 2024 #2125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davidsemakula merged 11 commits into from
Sep 9, 2025
Merged

chore: Upgrade to Rust edition 2024 #2125

davidsemakula merged 11 commits into from
Sep 9, 2025

Conversation

@davidsemakula
Copy link
Collaborator

@davidsemakula davidsemakula commented Sep 8, 2025 •
edited
Loading

Summary

Follow up to use-ink/ink#2624
Closes use-ink/ink-alliance#43
Also closes #2073

  • [y] y/n | Does it introduce breaking changes?
  • [y] y/n | Is it dependent on the specific version of ink or pallet-contracts?

Description

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have added an entry to CHANGELOG.md
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

@davidsemakula davidsemakula mentioned this pull request Sep 8, 2025
Merged
5 tasks
@davidsemakula davidsemakula marked this pull request as ready for review September 8, 2025 22:00
@davidsemakula davidsemakula mentioned this pull request Sep 8, 2025
Closed
cmichi
cmichi reviewed Sep 8, 2025
View reviewed changes
cmichi
cmichi reviewed Sep 8, 2025
View reviewed changes
cmichi
cmichi approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@cmichi cmichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsemakula davidsemakula merged commit e2d9049 into master Sep 9, 2025
17 checks passed
@davidsemakula davidsemakula deleted the semakula/rust-edition branch September 9, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmichi cmichi cmichi approved these changes

@AlexD10S AlexD10S Awaiting requested review from AlexD10S AlexD10S is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

unsafe attribute error with Rust edition 2024 Upgrade to Rust edition 2024

3 participants

@davidsemakula @cmichi