Skip to content

Fix windows dylint build #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 11 commits into from
Aug 15, 2022
Merged

Fix windows dylint build #690

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f4752f0
Build dylint driver through rustup to fix windows build
ascjones Aug 12, 2022
2edc843
Install required toolchain
ascjones Aug 12, 2022
8092386
Fmt
ascjones Aug 12, 2022
0bcbf03
Try --no-self-update
ascjones Aug 12, 2022
a7f5f58
Oops
ascjones Aug 12, 2022
65ad614
Revert "Oops"
ascjones Aug 12, 2022
efb8294
Revert "Try --no-self-update"
ascjones Aug 12, 2022
e610743
Revert "Fmt"
ascjones Aug 12, 2022
24e7785
Revert "Install required toolchain"
ascjones Aug 12, 2022
e5b2efc
Revert "Build dylint driver through rustup to fix windows build"
ascjones Aug 12, 2022
4a6ad94
Copy windows workaround from dylint
ascjones Aug 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Fmt" 
This reverts commit 8092386.
  • Loading branch information
@ascjones
ascjones committed Aug 12, 2022
commit e610743da47a5297748c0d14e38e460b07b53ff0
17 changes: 9 additions & 8 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,14 +168,15 @@ fn build_and_zip_dylint_driver(
const NIGHTLY_TOOLCHAIN: &str = "nightly-2022-06-30";

let mut install_toolchain = Command::new("rustup");
install_toolchain.args(vec![
"toolchain",
"install",
NIGHTLY_TOOLCHAIN,
"--component",
"llvm-tools-preview",
"rustc-dev",
]);
install_toolchain
.args(vec![
"toolchain",
"install",
NIGHTLY_TOOLCHAIN,
"--component",
"llvm-tools-preview",
"rustc-dev",
]);

let child = install_toolchain
// Capture the stdout to return from this function as bytes
Expand Down