Skip to content

Add verify command #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HCastano wants to merge 21 commits into from
Closed

Add verify command #696

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
51117cc
Add skeleton of `Verify` command
HCastano Aug 10, 2022
13d29dc
Read `BuildInfo` from contract metadata
HCastano Aug 10, 2022
85ccd7d
Manually build contract using `BuildInfo`
HCastano Aug 10, 2022
7de595c
Check built Wasm file against that in the reference metadata
HCastano Aug 11, 2022
e67d108
Comopare `SourceWasm`'s instead of byte strings
HCastano Aug 11, 2022
b90f126
Check that current `nightly` matches that from contract
HCastano Aug 15, 2022
a350f4c
Switch from `env_logger` to `tracing`
HCastano Aug 18, 2022
e87c51a
Use helper function to get current Rust toolchain
HCastano Aug 18, 2022
4317f55
Clean up docs a little
HCastano Aug 18, 2022
fed9c3f
Bail out if `wasm-opt` versions don't match
HCastano Aug 19, 2022
b743987
Use stable `rustc` toolchain
HCastano Aug 29, 2022
f6770de
Use `keep_debug_symbols` from metadata
HCastano Sep 29, 2022
2f3ca03
Make output more colourful
HCastano Sep 29, 2022
e2c5675
Add missing doc comment
HCastano Sep 29, 2022
963387c
Do a better job of error handling
HCastano Sep 29, 2022
e7b9577
Add more error handling improvements
HCastano Sep 29, 2022
a64b631
Add `CHANGELOG` entry
HCastano Sep 29, 2022
d6db73f
Appease Clippy
HCastano Sep 29, 2022
80233c4
Use updated Rust toolchain build info
HCastano Oct 20, 2022
98cc7fb
Apply fixes for `clap` `v4.0`
HCastano Oct 20, 2022
b2d10c2
Compare `cargo-contract` versions instead of `wasm-opt` versions
HCastano Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use keep_debug_symbols from metadata
  • Loading branch information
@HCastano
HCastano committed Oct 20, 2022
commit f6770dedf217997d52fcc45ed0cc946bc6ecf3a9
3 changes: 1 addition & 2 deletions crates/cargo-contract/src/cmd/verify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,7 @@ impl VerifyCommand {
);

let expected_wasm_opt_version = build_info.wasm_opt_settings.version;
// TODO: Will either want to add this to BuildInfo or assume release (so no)
let keep_debug_symbols = false;
let keep_debug_symbols = build_info.wasm_opt_settings.keep_debug_symbols;
let handler = crate::wasm_opt::WasmOptHandler::new(
build_info.wasm_opt_settings.optimization_passes,
keep_debug_symbols,
Expand Down