Skip to content

Skip linting if running building in --offline mode #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HCastano merged 4 commits into from
Sep 13, 2022
Merged

Skip linting if running building in --offline mode #737

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78cff43
Skip linting if running building in --offline mode
ascjones Sep 12, 2022
13c973f
Remove no-build flag
ascjones Sep 12, 2022
bb15bd6
Add comment
ascjones Sep 13, 2022
7cb4b0b
Fix typo
HCastano Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/cargo-contract/src/cmd/build/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ impl BuildCommand {
false => Network::Online,
};

// The invocation of `cargo dylint` requires network access, so in offline mode the linting
// step must be skipped otherwise the build can fail.
let skip_linting = self.skip_linting || matches!(network, Network::Offline);
Copy link
Contributor

@HCastano HCastano Sep 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd add a comment as to why we skip linting in this case


let output_type = match self.output_json {
true => OutputType::Json,
false => OutputType::HumanReadable,
Expand All @@ -207,7 +211,7 @@ impl BuildCommand {
unstable_flags,
optimization_passes,
keep_debug_symbols: self.keep_debug_symbols,
skip_linting: self.skip_linting,
skip_linting,
output_type,
};

Expand Down