Extract lib for invoking contract build #787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
approved these changes
Nov 30, 2022
Collaborator
Author
Contributor
|
@ascjones can you update the crate's owners to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new crate
contract-buildwhich allows building ofink!projects via a library interface.3rd party Rust tools can use this crate instead of invoking the
cargo-contractbinary. This has the advantage of being more robust since:cargo-contracton their machinecontract-buildfunctionality, avoiding compatibility issues.Note to reviewers
Almost all changes here are simply moving code around, so I won't change any bad code that I have copied from one location to another. I have noted a few things that can be improved/refactored (as ever), but I wanted to do the minimal changes required to extract the library for this PR.
Future steps
Extract extrinsics functionality into a library