Skip to content

Align example names with integration-tests, fix CI #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ascjones merged 6 commits into from
Aug 24, 2023
Merged

Align example names with integration-tests, fix CI #39

ascjones merged 6 commits into from
Aug 24, 2023

Conversation

@ascjones
Copy link
Collaborator

@ascjones ascjones commented Aug 24, 2023 •
edited
Loading

  • use hyphens instead of underscores for examples as per integration-tests on master
  • remove upgradeable-contracts (gone on master)
  • run CI on PRs for any change to examples in order to require they all build before merging

@ascjones ascjones merged commit 616ac4c into main Aug 24, 2023
@ascjones ascjones mentioned this pull request Sep 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SkymanOne SkymanOne SkymanOne approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ascjones @SkymanOne