Skip to content

Conversation

@cmichi
Copy link
Collaborator

@cmichi cmichi commented Nov 24, 2021

@cmichi cmichi requested a review from athei November 24, 2021 14:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 24, 2021

Codecov Report

Merging #1041 (0694503) into master (9ea95ff) will increase coverage by 15.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1041       +/-   ##
===========================================
+ Coverage   63.72%   78.74%   +15.01%     
===========================================
  Files         248      248               
  Lines        9361     9361               
===========================================
+ Hits         5965     7371     +1406     
+ Misses       3396     1990     -1406     
Impacted Files Coverage Δ
crates/lang/ir/src/ir/attrs.rs 82.87% <0.00%> (+3.59%) ⬆️
crates/lang/ir/src/ir/trait_def/item/mod.rs 90.16% <0.00%> (+4.91%) ⬆️
crates/lang/ir/src/ir/item_impl/constructor.rs 92.30% <0.00%> (+6.15%) ⬆️
crates/engine/src/ext.rs 73.42% <0.00%> (+6.99%) ⬆️
crates/lang/ir/src/ir/idents_lint.rs 71.42% <0.00%> (+9.52%) ⬆️
crates/lang/ir/src/ir/item_impl/callable.rs 91.91% <0.00%> (+14.14%) ⬆️
crates/lang/ir/src/ir/item_impl/message.rs 92.13% <0.00%> (+14.60%) ⬆️
crates/lang/ir/src/ir/selector.rs 88.00% <0.00%> (+16.00%) ⬆️
crates/lang/ir/src/ir/item/mod.rs 60.71% <0.00%> (+16.66%) ⬆️
crates/lang/ir/src/ir/item_impl/impl_item.rs 57.44% <0.00%> (+17.02%) ⬆️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea95ff...0694503. Read the comment docs.

Comment on lines +350 to +351
#[link(wasm_import_module = "__unstable__")]
extern "C" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should've been removed in #1036, no? Do you need to merge master?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still seal_ecdsa_recover which is unstable, but I just merged master and there were some conflicts to resolve because of that PR, so good to merge nontheless.

Copy link
Contributor

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification 👍

@paritytech-ci
Copy link

🦑 📈 ink! Example Contracts ‒ Size Change Report 📉 🦑

These are the results of building the examples/* contracts from this branch with cargo-contract 0.15.0:

Δ Original Size Δ Optimized Size Total Optimized Size
accumulator 6.13 K
adder -0.01 K -0.01 K 7.36 K
contract-terminate 1.50 K
contract-transfer 8.09 K
delegator -0.01 K -0.01 K 10.42 K
dns 22.05 K
erc1155 -0.01 K -0.01 K 45.71 K
erc20 10.40 K
erc721 36.12 K
flipper 2.02 K
incrementer 1.92 K
multisig -0.01 K -0.01 K 45.82 K
proxy -0.01 K -0.01 K 4.30 K
rand-extension 5.35 K
subber -0.01 K -0.01 K 7.37 K
trait-erc20 27.48 K
trait-flipper 1.83 K
trait-incrementer 1.91 K

Link to the run | Last update: Wed Nov 24 21:52:56 CET 2021

@cmichi cmichi merged commit 71a2c38 into master Nov 24, 2021
@cmichi cmichi deleted the cmichi-stabilize-seal-call branch November 24, 2021 20:58
xgreenx pushed a commit to Supercolony-net/ink that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants