Skip to content

Remove Default implementation for AccountId #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascjones merged 14 commits into from
Feb 1, 2023
Merged

Remove Default implementation for AccountId #1255

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
8472286
Remove `Default` bound on `AccountId` type
HCastano May 16, 2022
c05dcf8
Manually implement storage traits for AccountID
HCastano May 16, 2022
e3037a2
Update `Call` builder to not use default AccountId
HCastano May 16, 2022
909af82
Use non-Default bound functions when reading AccountIds
HCastano May 18, 2022
3957494
Remove unused `get_property_inplace` method
HCastano May 18, 2022
5419bd6
Update `CallParams` to use `None` when no account ID is set
HCastano May 18, 2022
823eebb
Update examples to explicitly use zero address
HCastano May 18, 2022
7ae8eec
Merge branch 'master' into hc-remove-default-account-id
HCastano Feb 1, 2023
ca4c212
Remove unused environment function
HCastano Feb 1, 2023
2c2cc44
Manually implement `Default` in DNS example
HCastano Feb 1, 2023
71fa03f
Fix spellcheck
HCastano Feb 1, 2023
ca9d24d
Correctly encode the `callee` account ID when calling `pallet-contracts`
HCastano Feb 1, 2023
b7feae2
Update `CHANGELOG`
HCastano Feb 1, 2023
c86692f
Make cross-contract callee non-optional (#1636)
ascjones Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CHANGELOG
  • Loading branch information
@HCastano
HCastano committed Feb 1, 2023
commit b7feae2dcbbfab49a01aec4206e48b4a0821fb02
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]
- Rename `_checked` codegen call methods with `try_` ‒ [#1621](https://github.com/paritytech/ink/pull/1621)
- Remove `Default` implementation for AccountId ‒ [#1255](https://github.com/paritytech/ink/pull/1255)

### Breaking Changes

1. We've renamed some of the generated message methods on the `ContractRef` struct. They
have been changed from `_checked` to `try_` ([#1621](https://github.com/paritytech/ink/pull/1621))
1. We have removed the `Default` implementation for `AccountId`s. This is because of
security concerns around the use of the zero address which has a known private key in
the `sr25519` and `ed25519` curves ([#1255](https://github.com/paritytech/ink/pull/1255)).

## Version 4.0.0-beta.1
The coolest feature included in this release is the first first published version of
Expand Down