-
Notifications
You must be signed in to change notification settings - Fork 480
Replace Mapping::insert_return_size with Mapping::insert
#1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
3f592fe
remove insert and replace with insert_size
lean-apple 628e166
Merge branch 'master' into ln-rename-master
lean-apple 9180e79
attempt to fix linting
lean-apple 57451f5
fix fmt for contract tests
lean-apple f59dddd
rename insert_return_size with shorter name
lean-apple fc26b92
fix fmt for examples
lean-apple 033320d
update changelog file
lean-apple ff3d866
update with current changelog
lean-apple 330d942
fix changelog file
lean-apple d9f4b5e
complete method docs
lean-apple File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,21 +130,11 @@ where | |
| V: Packed, | ||
| KeyType: StorageKey, | ||
| { | ||
| /// Insert the given `value` to the contract storage. | ||
| #[inline] | ||
| pub fn insert<Q, R>(&mut self, key: Q, value: &R) | ||
| where | ||
| Q: scale::EncodeLike<K>, | ||
| R: Storable + scale::EncodeLike<V>, | ||
| { | ||
| ink_env::set_contract_storage(&(&KeyType::KEY, key), value); | ||
| } | ||
|
|
||
| /// Insert the given `value` to the contract storage. | ||
| /// | ||
| /// Returns the size of the pre-existing value at the specified key if any. | ||
| /// Returns the size in bytes of the pre-existing value at the specified key if any. | ||
| #[inline] | ||
| pub fn insert_return_size<Q, R>(&mut self, key: Q, value: &R) -> Option<u32> | ||
| pub fn insert<Q, R>(&mut self, key: Q, value: &R) -> Option<u32> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the docs can you also specify the returned size is in bytes? |
||
| where | ||
| Q: scale::EncodeLike<K>, | ||
| R: Storable + scale::EncodeLike<V>, | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.