Skip to content

Conversation

@agryaznov
Copy link
Contributor

Follow-up to substrate#12781: there's no __unstable__ module anymore

@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #1522 (7596df3) into master (dc62b4f) will decrease coverage by 6.61%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
- Coverage   71.72%   65.10%   -6.62%     
==========================================
  Files         204      204              
  Lines        6316     6314       -2     
==========================================
- Hits         4530     4111     -419     
- Misses       1786     2203     +417     
Impacted Files Coverage Δ
crates/ink/ir/src/ir/contract.rs 0.00% <0.00%> (-100.00%) ⬇️
crates/ink/ir/src/ir/ink_test.rs 0.00% <0.00%> (-87.50%) ⬇️
crates/ink/ir/src/ir/trait_def/mod.rs 0.00% <0.00%> (-81.82%) ⬇️
crates/ink/ir/src/ir/storage_item/mod.rs 0.00% <0.00%> (-73.92%) ⬇️
crates/ink/ir/src/ir/storage_item/config.rs 0.00% <0.00%> (-73.34%) ⬇️
crates/ink/ir/src/ir/blake2.rs 20.83% <0.00%> (-58.34%) ⬇️
crates/ink/ir/src/ir/trait_def/config.rs 7.14% <0.00%> (-57.15%) ⬇️
crates/ink/ir/src/ir/trait_def/item/trait_item.rs 45.90% <0.00%> (-45.91%) ⬇️
crates/ink/ir/src/ir/config.rs 64.00% <0.00%> (-36.00%) ⬇️
crates/ink/ir/src/ir/utils.rs 57.40% <0.00%> (-35.19%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@athei
Copy link
Contributor

athei commented Nov 26, 2022

Can you add some docs to the imported function and the user facing Mapping::take to warn about the instability? You can link to the pallet-contracts README sub section describing unstable from there, too.

@agryaznov agryaznov merged commit 78c05df into master Nov 29, 2022
@agryaznov agryaznov deleted the ag-unstable branch November 29, 2022 17:17
deuszx added a commit to Cardinal-Cryptography/ink4-migration that referenced this pull request Jan 7, 2023
It's not available on production chains, even though it does exist in the code. For more details, see:
- paritytech/substrate#12781
- use-ink/ink#1522
- use-ink/cargo-contract#846
@ascjones ascjones mentioned this pull request Jan 12, 2023
@HCastano HCastano mentioned this pull request Jan 24, 2023
@ascjones ascjones mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants