Skip to content

Clean up CallBuilder return() type #1525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HCastano merged 23 commits into from
Jan 19, 2023
Merged

Clean up CallBuilder return() type #1525

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b211af1
Assume that `CallBuilder`s return a `MessageResult`
HCastano Nov 30, 2022
5b9b1f1
Add `try_*` variants to `CallBuilder`
HCastano Nov 30, 2022
65edbfe
Add doc test showing how to handle `LangError` from `build_call`
HCastano Nov 30, 2022
caba49c
Remove TODO related to `delegate_call`
HCastano Nov 30, 2022
6e00bae
Merge branch 'master' into hc-clean-up-call-builder-return
HCastano Jan 15, 2023
a258897
Account for `LangError` in E2E tests
HCastano Jan 15, 2023
d8fb710
Improve `return_value` error message
HCastano Jan 16, 2023
cb22885
Remove extra `expect` from E2E tests
HCastano Jan 16, 2023
313780d
Add test for checking that `fire` panics on `LangError`
HCastano Jan 16, 2023
2710f17
Fix spelling
HCastano Jan 16, 2023
f03b929
Remove extra `unwrap` in more E2E tests
HCastano Jan 16, 2023
5a6934d
Fix ERC-1155 example
HCastano Jan 16, 2023
1716f88
Fix `invoke_contract` doc test
HCastano Jan 16, 2023
1b6beec
RustFmt
HCastano Jan 16, 2023
b3f8888
Fix `delegator` example
HCastano Jan 16, 2023
09e1b53
Update ERC-20 tests
HCastano Jan 16, 2023
a662d99
Indicate that doc test panics in off-chain env
HCastano Jan 16, 2023
782ed2e
Forgot some commas 🤦
HCastano Jan 16, 2023
ffd3926
Get `Flipper` example compiling again
HCastano Jan 16, 2023
84b5924
Remove more unwraps
HCastano Jan 16, 2023
2c21791
Update UI tests
HCastano Jan 16, 2023
63d7b1c
Print out `LangError` when panicking after `invoke`
HCastano Jan 18, 2023
51af07e
Bump `scale` to fix UI tests
HCastano Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
RustFmt
  • Loading branch information
@HCastano
HCastano committed Jan 16, 2023
commit 1b6beecc51c0baec32aaa557630276218bd9ac4d
4 changes: 2 additions & 2 deletions crates/ink/src/env_access.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ where
/// # Example
///
/// ```
///
///
/// #[ink::contract]
/// pub mod only_owner {
/// #[ink(storage)]
Expand Down Expand Up @@ -342,7 +342,7 @@ where
/// # Example
///
/// ```
///
///
/// #[ink::contract]
/// pub mod my_contract {
/// #[ink(storage)]
Expand Down