Fix trait message return type metadata #1531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
approved these changes
Dec 8, 2022
| } | ||
|
|
||
| #[test] | ||
| fn trait_message_metadata_return_value_is_result() { |
Contributor
There was a problem hiding this comment.
For the sake of completeness, we may also want to add tests for inherent messages, inherent fallible messages, etc.
Right now as long as the tests inlang-err-integration-tests work our metadata stuff is probably fine, but it would be nice to be more explicit with our checks
Collaborator
Author
There was a problem hiding this comment.
Agree, we need more tests for the metadata like this. Work for a follow-on PR methinks.
7 tasks
Closed
HCastano
pushed a commit
that referenced
this pull request
Jan 23, 2023
* Add failing message return type metadata test * Set wrapped return type for trait message * Combine existing contractor metadata test * Common extract result function * Refactor fallible constructor test to use helpers * Remove dummy test * Fix clippy warning
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #1450, addresses the metadata part of #1530.
Messages now return
Result<_, LangError>. The metadata was updated to reflect this for inherent methods but not for trait methods.Note that as mentioned in the #1530, this only fixes the external metadata, and does not address the codegen for cross contract calling.
Additionally this PR copies a similar test for fallible constructor metadata from one of the compile tests, and allows it to use the helpers for extracting result types here.